RULEAPI-770 Fix bug due to multiple sonarpedia.json files #3983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johann-beleites-sonarsource
added
the
rspec system
johann-beleites-sonarsource
force-pushed
the
jb/RULEAPI-770
branch
2 times, most recently
from
9306f34 to
19a94bb
Compare
When there are multiple sonarpedia.json files for the same language, the rules picked up for the next sonarpedia.json file will override the ones picked up previously. With this fix, the rules are not overwritten but all are collected, so one repository can have multiple sonarpedia.json files for the same language.
johann-beleites-sonarsource
force-pushed
the
jb/RULEAPI-770
branch
2 times, most recently
from
773ffd4 to
87eaf86
Compare
frederic-tingaud-sonarsource
requested changes
Jun 10, 2024
johann-beleites-sonarsource
force-pushed
the
jb/RULEAPI-770
branch
from
acb3621 to
f5ec7dd
Compare
johann-beleites-sonarsource
force-pushed
the
jb/RULEAPI-770
branch
from
f5ec7dd to
3ad3581
Compare
|
|
frederic-tingaud-sonarsource
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple sonarpedia.json files for the same language, the rules picked up for the next sonarpedia.json file will override the ones picked up previously. With this fix, the rules are not overwritten but all are collected, so one repository can have multiple sonarpedia.json files for the same language.